Skip to content

Commit de66b37

Browse files
floatiouskwilczynski
authored andcommitted
PCI: rockchip-ep: Set a 64-bit BAR if requested
Ever since commit f25b5fa ("PCI: endpoint: Setting a BAR size > 4 GB is invalid if 64-bit flag is not set") it has been impossible to get the .set_bar() callback with a BAR size > 2 GB (yes, 2GB!), if the BAR was also not requested to be configured as a 64-bit BAR. It is however possible that an EPF driver configures a BAR as 64-bit, even if the requested size is < 4 GB. Respect the requested BAR configuration, just like how it is already respected with regards to the prefetchable bit. Link: https://lore.kernel.org/linux-pci/20240320113157.322695-8-cassel@kernel.org Signed-off-by: Niklas Cassel <cassel@kernel.org> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
1 parent 4cece76 commit de66b37

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/pci/controller/pcie-rockchip-ep.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ static int rockchip_pcie_ep_set_bar(struct pci_epc *epc, u8 fn, u8 vfn,
153153
ctrl = ROCKCHIP_PCIE_CORE_BAR_CFG_CTRL_IO_32BITS;
154154
} else {
155155
bool is_prefetch = !!(flags & PCI_BASE_ADDRESS_MEM_PREFETCH);
156-
bool is_64bits = sz > SZ_2G;
156+
bool is_64bits = !!(flags & PCI_BASE_ADDRESS_MEM_TYPE_64);
157157

158158
if (is_64bits && (bar & 1))
159159
return -EINVAL;

0 commit comments

Comments
 (0)