Skip to content

Commit de90521

Browse files
SukrutHerookarAndreas Gruenbacher
authored andcommitted
gfs2: document ip in __gfs2_holder_init kernel-doc comment
Building with W=1 reports: Warning: fs/gfs2/glock.c:1248 function parameter 'ip' not described in '__gfs2_holder_init' The ip parameter was added when __gfs2_holder_init started saving the gfs2_glock_nq_init caller's return address to gh_ip. This makes it easier to backtrack which holder took the lock. Document @ip to silence this warning. Fixes: b016d9a ("gfs2: Save ip from gfs2_glock_nq_init") Signed-off-by: Sukrut Heroorkar <hsukrut3@gmail.com> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
1 parent 620fc27 commit de90521

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/gfs2/glock.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1241,7 +1241,7 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number,
12411241
* @state: the state we're requesting
12421242
* @flags: the modifier flags
12431243
* @gh: the holder structure
1244-
*
1244+
* @ip: caller's return address for debugging
12451245
*/
12461246

12471247
void __gfs2_holder_init(struct gfs2_glock *gl, unsigned int state, u16 flags,

0 commit comments

Comments
 (0)