Skip to content

Commit de9414a

Browse files
foxhlchenJonathan Corbet
authored andcommitted
docs: path-lookup: update WALK_GET, WALK_PUT desc
WALK_GET is changed to WALK_TRAILING with a different meaning. Here it should be WALK_NOFOLLOW. WALK_PUT dosn't exist, we have WALK_MORE. WALK_PUT == !WALK_MORE And there is not should_follow_link(). Related commits: commit 8c4efe2 ("namei: invert the meaning of WALK_FOLLOW") commit 1c4ff1a ("namei: invert WALK_PUT logics") Signed-off-by: Fox Chen <foxhlchen@gmail.com> Reviewed-by: NeilBrown <neilb@suse.de> [jc: applied language tweaks suggested by Neil] Link: https://lore.kernel.org/r/20210527091618.287093-11-foxhlchen@gmail.com Signed-off-by: Jonathan Corbet <corbet@lwn.net>
1 parent 18edb95 commit de9414a

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

Documentation/filesystems/path-lookup.rst

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1123,13 +1123,13 @@ stack in ``walk_component()`` immediately when the symlink is found;
11231123
old symlink as it walks that last component. So it is quite
11241124
convenient for ``walk_component()`` to release the old symlink and pop
11251125
the references just before pushing the reference information for the
1126-
new symlink. It is guided in this by two flags; ``WALK_GET``, which
1127-
gives it permission to follow a symlink if it finds one, and
1128-
``WALK_PUT``, which tells it to release the current symlink after it has been
1129-
followed. ``WALK_PUT`` is tested first, leading to a call to
1130-
``put_link()``. ``WALK_GET`` is tested subsequently (by
1131-
``should_follow_link()``) leading to a call to ``pick_link()`` which sets
1132-
up the stack frame.
1126+
new symlink. It is guided in this by three flags: ``WALK_NOFOLLOW`` which
1127+
forbids it from following a symlink if it finds one, ``WALK_MORE``
1128+
which indicates that it is yet too early to release the
1129+
current symlink, and ``WALK_TRAILING`` which indicates that it is on the final
1130+
component of the lookup, so we will check userspace flag ``LOOKUP_FOLLOW`` to
1131+
decide whether follow it when it is a symlink and call ``may_follow_link()`` to
1132+
check if we have privilege to follow it.
11331133

11341134
Symlinks with no final component
11351135
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

0 commit comments

Comments
 (0)