x86/resctrl: Remove redundant assignment to variable chunks

ColinIanKing · hansendc · commit df0114f1f871 · 2021-12-09T09:57:16.000-08:00
The variable chunks is being shifted right and re-assinged the shifted value which is then returned. Since chunks is not being read afterwards the assignment is redundant and the >>= operator can be replaced with a shift >> operator instead. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com> Link: https://lkml.kernel.org/r/20211207223735.35173-1-colin.i.king@gmail.com
diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
@@ -282,7 +282,7 @@ static u64 mbm_overflow_count(u64 prev_msr, u64 cur_msr, unsigned int width)
 	u64 shift = 64 - width, chunks;
 
 	chunks = (cur_msr << shift) - (prev_msr << shift);
-	return chunks >>= shift;
+	return chunks >> shift;
 }
 
 static u64 __mon_event_count(u32 rmid, struct rmid_read *rr)

Original file line number	Diff line number	Diff line change
`@@ -282,7 +282,7 @@ static u64 mbm_overflow_count(u64 prev_msr, u64 cur_msr, unsigned int width)`
`282`	`282`	`u64 shift = 64 - width, chunks;`
`283`	`283`
`284`	`284`	`chunks = (cur_msr << shift) - (prev_msr << shift);`
`285`		`- return chunks >>= shift;`
	`285`	`+ return chunks >> shift;`
`286`	`286`	`}`
`287`	`287`
`288`	`288`	`static u64 __mon_event_count(u32 rmid, struct rmid_read *rr)`