Skip to content

Commit df5b4ac

Browse files
Jianglei Niebroonie
authored andcommitted
ASoC: qdsp6: fix potential memory leak in q6apm_get_audioreach_graph()
q6apm_get_audioreach_graph() allocates a memory chunk for graph->graph with audioreach_alloc_graph_pkt(). When idr_alloc() fails, graph->graph is not released, which will lead to a memory leak. We can release the graph->graph with kfree() when idr_alloc() fails to fix the memory leak. Signed-off-by: Jianglei Nie <niejianglei2021@163.com> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Link: https://lore.kernel.org/r/20220629182520.2164409-1-niejianglei2021@163.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 1c4f29e commit df5b4ac

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

sound/soc/qcom/qdsp6/q6apm.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ static struct audioreach_graph *q6apm_get_audioreach_graph(struct q6apm *apm, ui
7575
id = idr_alloc(&apm->graph_idr, graph, graph_id, graph_id + 1, GFP_KERNEL);
7676
if (id < 0) {
7777
dev_err(apm->dev, "Unable to allocate graph id (%d)\n", graph_id);
78+
kfree(graph->graph);
7879
kfree(graph);
7980
mutex_unlock(&apm->lock);
8081
return ERR_PTR(id);

0 commit comments

Comments
 (0)