Skip to content

Commit df8c841

Browse files
bagasmechucklever
authored andcommitted
NFSD: nfsd-io-modes: Separate lists
Sphinx reports htmldocs indentation warnings: Documentation/filesystems/nfs/nfsd-io-modes.rst:58: ERROR: Unexpected indentation. [docutils] Documentation/filesystems/nfs/nfsd-io-modes.rst:59: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] These caused the lists to be shown as long running paragraphs merged with their previous paragraphs. Fix these by separating the lists with a blank line. Fixes: fa8d4e6 ("NFSD: add Documentation/filesystems/nfs/nfsd-io-modes.rst") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Closes: https://lore.kernel.org/linux-next/20251202152506.7a2d2d41@canb.auug.org.au/ Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com> Reviewed-by: Jeff Layton <jlayton@kernel.org> Reviewed-by: Randy Dunlap <rdunlap@infradead.org> Tested-by: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent 4fcf995 commit df8c841

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

Documentation/filesystems/nfs/nfsd-io-modes.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,15 @@ to override that default to use either DONTCACHE or DIRECT IO modes.
1313

1414
Experimental NFSD debugfs interfaces are available to allow the NFSD IO
1515
mode used for READ and WRITE to be configured independently. See both:
16+
1617
- /sys/kernel/debug/nfsd/io_cache_read
1718
- /sys/kernel/debug/nfsd/io_cache_write
1819

1920
The default value for both io_cache_read and io_cache_write reflects
2021
NFSD's default IO mode (which is NFSD_IO_BUFFERED=0).
2122

2223
Based on the configured settings, NFSD's IO will either be:
24+
2325
- cached using page cache (NFSD_IO_BUFFERED=0)
2426
- cached but removed from page cache on completion (NFSD_IO_DONTCACHE=1)
2527
- not cached stable_how=NFS_UNSTABLE (NFSD_IO_DIRECT=2)
@@ -56,6 +58,7 @@ because the page cache will eventually become a bottleneck to servicing
5658
new IO requests.
5759

5860
For more context on DONTCACHE, please see these Linux commit headers:
61+
5962
- Overview: 9ad6344568cc3 ("mm/filemap: change filemap_create_folio()
6063
to take a struct kiocb")
6164
- for READ: 8026e49bff9b1 ("mm/filemap: add read support for
@@ -87,7 +90,9 @@ be made.
8790
The performance win associated with using NFSD DIRECT was previously
8891
discussed on linux-nfs, see:
8992
https://lore.kernel.org/linux-nfs/aEslwqa9iMeZjjlV@kernel.org/
93+
9094
But in summary:
95+
9196
- NFSD DIRECT can significantly reduce memory requirements
9297
- NFSD DIRECT can reduce CPU load by avoiding costly page reclaim work
9398
- NFSD DIRECT can offer more deterministic IO performance

0 commit comments

Comments
 (0)