Skip to content

Commit dfca045

Browse files
vladimirolteankuba-moo
authored andcommitted
net: dsa: fix off-by-one in maximum bridge ID determination
Prior to the blamed commit, the bridge_num range was from 0 to ds->max_num_bridges - 1. After the commit, it is from 1 to ds->max_num_bridges. So this check: if (bridge_num >= max) return 0; must be updated to: if (bridge_num > max) return 0; in order to allow the last bridge_num value (==max) to be used. This is easiest visible when a driver sets ds->max_num_bridges=1. The observed behaviour is that even the first created bridge triggers the netlink extack "Range of offloadable bridges exceeded" warning, and is handled in software rather than being offloaded. Fixes: 3f9bb03 ("net: dsa: make dp->bridge_num one-based") Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Link: https://patch.msgid.link/20260120211039.3228999-1-vladimir.oltean@nxp.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent bbb11b8 commit dfca045

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

net/dsa/dsa.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ unsigned int dsa_bridge_num_get(const struct net_device *bridge_dev, int max)
158158
bridge_num = find_next_zero_bit(&dsa_fwd_offloading_bridges,
159159
DSA_MAX_NUM_OFFLOADING_BRIDGES,
160160
1);
161-
if (bridge_num >= max)
161+
if (bridge_num > max)
162162
return 0;
163163

164164
set_bit(bridge_num, &dsa_fwd_offloading_bridges);

0 commit comments

Comments
 (0)