Skip to content

Commit dff645f

Browse files
committed
Merge branch 'pci/misc'
- Fix documentation typos (Shawn Lin) - Add struct p2pdma_provider kernel doc (Leon Romanovsky) - Remove useless devres WARN_ON() (Philipp Stanner) * pci/misc: PCI: Remove useless WARN_ON() from devres PCI/P2PDMA: Add missing struct p2pdma_provider documentation Documentation: PCI: Fix typos in msi-howto.rst
2 parents 522a46a + 94cf23f commit dff645f

3 files changed

Lines changed: 5 additions & 6 deletions

File tree

Documentation/PCI/msi-howto.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ function::
9898

9999
which allocates up to max_vecs interrupt vectors for a PCI device. It
100100
returns the number of vectors allocated or a negative error. If the device
101-
has a requirements for a minimum number of vectors the driver can pass a
101+
has a requirement for a minimum number of vectors the driver can pass a
102102
min_vecs argument set to this limit, and the PCI core will return -ENOSPC
103103
if it can't meet the minimum number of vectors.
104104

@@ -127,7 +127,7 @@ not be able to allocate as many vectors for MSI as it could for MSI-X. On
127127
some platforms, MSI interrupts must all be targeted at the same set of CPUs
128128
whereas MSI-X interrupts can all be targeted at different CPUs.
129129

130-
If a device supports neither MSI-X or MSI it will fall back to a single
130+
If a device supports neither MSI-X nor MSI it will fall back to a single
131131
legacy IRQ vector.
132132

133133
The typical usage of MSI or MSI-X interrupts is to allocate as many vectors
@@ -203,7 +203,7 @@ How to tell whether MSI/MSI-X is enabled on a device
203203
----------------------------------------------------
204204

205205
Using 'lspci -v' (as root) may show some devices with "MSI", "Message
206-
Signalled Interrupts" or "MSI-X" capabilities. Each of these capabilities
206+
Signaled Interrupts" or "MSI-X" capabilities. Each of these capabilities
207207
has an 'Enable' flag which is followed with either "+" (enabled)
208208
or "-" (disabled).
209209

drivers/pci/devres.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -469,9 +469,6 @@ static int pcim_add_mapping_to_legacy_table(struct pci_dev *pdev,
469469
if (!legacy_iomap_table)
470470
return -ENOMEM;
471471

472-
/* The legacy mechanism doesn't allow for duplicate mappings. */
473-
WARN_ON(legacy_iomap_table[bar]);
474-
475472
legacy_iomap_table[bar] = mapping;
476473

477474
return 0;

include/linux/pci-p2pdma.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ struct scatterlist;
2020
* struct p2pdma_provider
2121
*
2222
* A p2pdma provider is a range of MMIO address space available to the CPU.
23+
* @owner: Device to which this provider belongs.
24+
* @bus_offset: Bus offset for p2p communication.
2325
*/
2426
struct p2pdma_provider {
2527
struct device *owner;

0 commit comments

Comments
 (0)