Skip to content

Commit e16e71e

Browse files
dlechbroonie
authored andcommitted
spi: axi-spi-engine: use devm_spi_register_controller()
This replaces spi_register_controller() with devm_spi_register_controller() in the AXI SPI Engine driver. This saves us from having to call spi_unregister_controller() in the remove function. The remove function is also removed since it is no longer needed. Signed-off-by: David Lechner <dlechner@baylibre.com> Link: https://lore.kernel.org/r/20231117-axi-spi-engine-series-1-v1-7-cc59db999b87@baylibre.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 076f32d commit e16e71e

1 file changed

Lines changed: 1 addition & 9 deletions

File tree

drivers/spi/spi-axi-spi-engine.c

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -532,7 +532,7 @@ static int spi_engine_probe(struct platform_device *pdev)
532532
host->transfer_one_message = spi_engine_transfer_one_message;
533533
host->num_chipselect = 8;
534534

535-
ret = spi_register_controller(host);
535+
ret = devm_spi_register_controller(&pdev->dev, host);
536536
if (ret)
537537
return ret;
538538

@@ -541,13 +541,6 @@ static int spi_engine_probe(struct platform_device *pdev)
541541
return 0;
542542
}
543543

544-
static void spi_engine_remove(struct platform_device *pdev)
545-
{
546-
struct spi_controller *host = platform_get_drvdata(pdev);
547-
548-
spi_unregister_controller(host);
549-
}
550-
551544
static const struct of_device_id spi_engine_match_table[] = {
552545
{ .compatible = "adi,axi-spi-engine-1.00.a" },
553546
{ },
@@ -556,7 +549,6 @@ MODULE_DEVICE_TABLE(of, spi_engine_match_table);
556549

557550
static struct platform_driver spi_engine_driver = {
558551
.probe = spi_engine_probe,
559-
.remove_new = spi_engine_remove,
560552
.driver = {
561553
.name = "spi-engine",
562554
.of_match_table = spi_engine_match_table,

0 commit comments

Comments
 (0)