Skip to content

Commit e18398e

Browse files
jpoimboePeter Zijlstra
authored andcommitted
Revert "objtool: Support addition to set CFA base"
Commit 468af56 ("objtool: Support addition to set CFA base") was added as a preparatory patch for arm64 support, but that support never came. It triggers a false positive warning on x86, so just revert it for now. Fixes the following warning: vmlinux.o: warning: objtool: cdce925_regmap_i2c_write+0xdb: stack state mismatch: cfa1=4+120 cfa2=5+40 Fixes: 468af56 ("objtool: Support addition to set CFA base") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lore.kernel.org/oe-kbuild-all/202304080538.j5G6h1AB-lkp@intel.com/
1 parent f571da0 commit e18398e

1 file changed

Lines changed: 0 additions & 11 deletions

File tree

tools/objtool/check.c

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3002,17 +3002,6 @@ static int update_cfi_state(struct instruction *insn,
30023002
break;
30033003
}
30043004

3005-
if (!cfi->drap && op->src.reg == CFI_SP &&
3006-
op->dest.reg == CFI_BP && cfa->base == CFI_SP &&
3007-
check_reg_frame_pos(&regs[CFI_BP], -cfa->offset + op->src.offset)) {
3008-
3009-
/* lea disp(%rsp), %rbp */
3010-
cfa->base = CFI_BP;
3011-
cfa->offset -= op->src.offset;
3012-
cfi->bp_scratch = false;
3013-
break;
3014-
}
3015-
30163005
if (op->src.reg == CFI_SP && cfa->base == CFI_SP) {
30173006

30183007
/* drap: lea disp(%rsp), %drap */

0 commit comments

Comments
 (0)