Skip to content

Commit e18533b

Browse files
billy-tsaiBartosz Golaszewski
authored andcommitted
gpio: aspeed-sgpio: Change the macro to support deferred probe
Use module_platform_driver() to replace module_platform_driver_probe(). The former utilizes platform_driver_register(), which allows the driver to defer probing when it doesn't acquire the necessary resources due to probe order. In contrast, the latter uses __platform_driver_probe(), which includes the comment "Note that this is incompatible with deferred probing." Since our SGPIO driver requires access to the clock resource, the former is more suitable. Reviewed-by: Linus Walleij <linusw@kernel.org> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> Link: https://lore.kernel.org/r/20260123-upstream_sgpio-v2-1-69cfd1631400@aspeedtech.com Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
1 parent 09b174f commit e18533b

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

drivers/gpio/gpio-aspeed-sgpio.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,7 @@ static const struct of_device_id aspeed_sgpio_of_table[] = {
516516

517517
MODULE_DEVICE_TABLE(of, aspeed_sgpio_of_table);
518518

519-
static int __init aspeed_sgpio_probe(struct platform_device *pdev)
519+
static int aspeed_sgpio_probe(struct platform_device *pdev)
520520
{
521521
u32 nr_gpios, sgpio_freq, sgpio_clk_div, gpio_cnt_regval, pin_mask;
522522
const struct aspeed_sgpio_pdata *pdata;
@@ -611,11 +611,12 @@ static int __init aspeed_sgpio_probe(struct platform_device *pdev)
611611
}
612612

613613
static struct platform_driver aspeed_sgpio_driver = {
614+
.probe = aspeed_sgpio_probe,
614615
.driver = {
615616
.name = KBUILD_MODNAME,
616617
.of_match_table = aspeed_sgpio_of_table,
617618
},
618619
};
619620

620-
module_platform_driver_probe(aspeed_sgpio_driver, aspeed_sgpio_probe);
621+
module_platform_driver(aspeed_sgpio_driver);
621622
MODULE_DESCRIPTION("Aspeed Serial GPIO Driver");

0 commit comments

Comments
 (0)