Skip to content

Commit e19089d

Browse files
LiBaokun96tytso
authored andcommitted
ext4: clean up s_mb_rb_lock to fix build warnings with C=1
Running sparse (make C=1) on mballoc.c we get the following warning: fs/ext4/mballoc.c:3194:13: warning: context imbalance in 'ext4_mb_seq_structs_summary_start' - wrong count at exit This is because __acquires(&EXT4_SB(sb)->s_mb_rb_lock) was called in ext4_mb_seq_structs_summary_start(), but s_mb_rb_lock was removed in commit 83e80a6 ("ext4: use buckets for cr 1 block scan instead of rbtree"), so remove the __acquires to silence the warning. Signed-off-by: Baokun Li <libaokun1@huawei.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20240319113325.3110393-10-libaokun1@huawei.com Signed-off-by: Theodore Ts'o <tytso@mit.edu>
1 parent 261341a commit e19089d

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

fs/ext4/mballoc.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3190,7 +3190,6 @@ int ext4_seq_mb_stats_show(struct seq_file *seq, void *offset)
31903190
}
31913191

31923192
static void *ext4_mb_seq_structs_summary_start(struct seq_file *seq, loff_t *pos)
3193-
__acquires(&EXT4_SB(sb)->s_mb_rb_lock)
31943193
{
31953194
struct super_block *sb = pde_data(file_inode(seq->file));
31963195
unsigned long position;

0 commit comments

Comments
 (0)