Skip to content

Commit e1c9223

Browse files
author
AngeloGioacchino Del Regno
committed
arm64: dts: mediatek: mt7988a: Fix PCI-Express T-PHY node address
The PCIe and USB TPHYs are under the soc bus, which provides MMIO, and all nodes under that must use the bus, otherwise those would clearly be out of place. Add ranges to both the tphy(s) and assign the address to the main node to silence a dtbs_check warning, and fix the children to use the MMIO range of t-phy. Fixes: ("f693e6ba55ae arm64: dts: mediatek: mt7988: Add t-phy for ssusb1") Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
1 parent 6159624 commit e1c9223

1 file changed

Lines changed: 14 additions & 14 deletions

File tree

arch/arm64/boot/dts/mediatek/mt7988a.dtsi

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -629,20 +629,20 @@
629629
tphy: t-phy@11c50000 {
630630
compatible = "mediatek,mt7986-tphy",
631631
"mediatek,generic-tphy-v2";
632-
#address-cells = <2>;
633-
#size-cells = <2>;
634-
ranges;
632+
#address-cells = <1>;
633+
#size-cells = <1>;
634+
ranges = <0 0 0x11c50000 0x1000>;
635635
status = "disabled";
636636

637-
tphyu2port0: usb-phy@11c50000 {
638-
reg = <0 0x11c50000 0 0x700>;
637+
tphyu2port0: usb-phy@0 {
638+
reg = <0 0x700>;
639639
clocks = <&infracfg CLK_INFRA_USB_UTMI_CK_P1>;
640640
clock-names = "ref";
641641
#phy-cells = <1>;
642642
};
643643

644-
tphyu3port0: usb-phy@11c50700 {
645-
reg = <0 0x11c50700 0 0x900>;
644+
tphyu3port0: usb-phy@700 {
645+
reg = <0x700 0x900>;
646646
clocks = <&infracfg CLK_INFRA_USB_PIPE_CK_P1>;
647647
clock-names = "ref";
648648
#phy-cells = <1>;
@@ -659,20 +659,20 @@
659659
xsphy: xs-phy@11e10000 {
660660
compatible = "mediatek,mt7988-xsphy",
661661
"mediatek,xsphy";
662-
#address-cells = <2>;
663-
#size-cells = <2>;
664-
ranges;
662+
#address-cells = <1>;
663+
#size-cells = <1>;
664+
ranges = <0 0 0x11e10000 0x3900>;
665665
status = "disabled";
666666

667-
xphyu2port0: usb-phy@11e10000 {
668-
reg = <0 0x11e10000 0 0x400>;
667+
xphyu2port0: usb-phy@0 {
668+
reg = <0 0x400>;
669669
clocks = <&infracfg CLK_INFRA_USB_UTMI>;
670670
clock-names = "ref";
671671
#phy-cells = <1>;
672672
};
673673

674-
xphyu3port0: usb-phy@11e13000 {
675-
reg = <0 0x11e13400 0 0x500>;
674+
xphyu3port0: usb-phy@3400 {
675+
reg = <0x3400 0x500>;
676676
clocks = <&infracfg CLK_INFRA_USB_PIPE>;
677677
clock-names = "ref";
678678
#phy-cells = <1>;

0 commit comments

Comments
 (0)