Skip to content

Commit e1e9651

Browse files
ZheyuMahdeller
authored andcommitted
video: fbdev: arkfb: Error out if 'pixclock' equals zero
The userspace program could pass any values to the driver through ioctl() interface. If the driver doesn't check the value of 'pixclock', it may cause divide error. Fix this by checking whether 'pixclock' is zero. The following log reveals it: divide error: 0000 [#1] PREEMPT SMP KASAN PTI RIP: 0010:arkfb_set_par+0x10fc/0x24f0 Call Trace: <TASK> fb_set_var+0x604/0xeb0 do_fb_ioctl+0x234/0x670 fb_ioctl+0xdd/0x130 do_syscall_64+0x3b/0x90 Signed-off-by: Zheyu Ma <zheyuma97@gmail.com> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent 16844e5 commit e1e9651

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

drivers/video/fbdev/arkfb.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -566,6 +566,9 @@ static int arkfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
566566
{
567567
int rv, mem, step;
568568

569+
if (!var->pixclock)
570+
return -EINVAL;
571+
569572
/* Find appropriate format */
570573
rv = svga_match_format (arkfb_formats, var, NULL);
571574
if (rv < 0)

0 commit comments

Comments
 (0)