Skip to content

Commit e1ec81e

Browse files
khayash1kwilczynski
authored andcommitted
misc: pci_endpoint_test: Do not use managed IRQ functions
The pci_endpoint_test_request_irq() and pci_endpoint_test_release_irq() are called repeatedly by the users through pci_endpoint_test_set_irq(). So using the managed version of IRQ functions within these functions has no effect. Suggested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> Acked-by: Arnd Bergmann <arnd@arndb.de> Link: https://lore.kernel.org/r/20250225110252.28866-7-hayashi.kunihiko@socionext.com Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
1 parent a402006 commit e1ec81e

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

drivers/misc/pci_endpoint_test.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -208,10 +208,9 @@ static void pci_endpoint_test_release_irq(struct pci_endpoint_test *test)
208208
{
209209
int i;
210210
struct pci_dev *pdev = test->pdev;
211-
struct device *dev = &pdev->dev;
212211

213212
for (i = 0; i < test->num_irqs; i++)
214-
devm_free_irq(dev, pci_irq_vector(pdev, i), test);
213+
free_irq(pci_irq_vector(pdev, i), test);
215214

216215
test->num_irqs = 0;
217216
}
@@ -224,9 +223,9 @@ static int pci_endpoint_test_request_irq(struct pci_endpoint_test *test)
224223
struct device *dev = &pdev->dev;
225224

226225
for (i = 0; i < test->num_irqs; i++) {
227-
ret = devm_request_irq(dev, pci_irq_vector(pdev, i),
228-
pci_endpoint_test_irqhandler,
229-
IRQF_SHARED, test->name, test);
226+
ret = request_irq(pci_irq_vector(pdev, i),
227+
pci_endpoint_test_irqhandler, IRQF_SHARED,
228+
test->name, test);
230229
if (ret)
231230
goto fail;
232231
}

0 commit comments

Comments
 (0)