Skip to content

Commit e269537

Browse files
Li Nanaxboe
authored andcommitted
block: clean up the check in blkdev_iomap_begin()
It is odd to check the offset amidst a series of assignments. Moving this check to the beginning of the function makes the code look better. Signed-off-by: Li Nan <linan122@huawei.com> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Link: https://lore.kernel.org/r/20240625115517.1472120-1-linan666@huaweicloud.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 69b6517 commit e269537

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

block/fops.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -394,10 +394,11 @@ static int blkdev_iomap_begin(struct inode *inode, loff_t offset, loff_t length,
394394
struct block_device *bdev = I_BDEV(inode);
395395
loff_t isize = i_size_read(inode);
396396

397-
iomap->bdev = bdev;
398-
iomap->offset = ALIGN_DOWN(offset, bdev_logical_block_size(bdev));
399397
if (offset >= isize)
400398
return -EIO;
399+
400+
iomap->bdev = bdev;
401+
iomap->offset = ALIGN_DOWN(offset, bdev_logical_block_size(bdev));
401402
iomap->type = IOMAP_MAPPED;
402403
iomap->addr = iomap->offset;
403404
iomap->length = isize - iomap->offset;

0 commit comments

Comments
 (0)