Skip to content

Commit e28ee1b

Browse files
AaronDotbroonie
authored andcommitted
ASoC: loongson: Simplify if statment in loongson_card_hw_params()
Deal with illegal conditions first and put the normal process code outside the if condition to improve code readability. Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> Link: https://patch.msgid.link/98b71f9643970f11bc500c01599c7aeb77ff2a58.1725844530.git.zhoubinbin@loongson.cn Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 3d2528d commit e28ee1b

1 file changed

Lines changed: 16 additions & 16 deletions

File tree

sound/soc/loongson/loongson_card.c

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -24,27 +24,27 @@ static int loongson_card_hw_params(struct snd_pcm_substream *substream,
2424
struct snd_pcm_hw_params *params)
2525
{
2626
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
27-
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
28-
struct snd_soc_dai *codec_dai = snd_soc_rtd_to_codec(rtd, 0);
2927
struct loongson_card_data *ls_card = snd_soc_card_get_drvdata(rtd->card);
28+
struct snd_soc_dai *codec_dai = snd_soc_rtd_to_codec(rtd, 0);
29+
struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
3030
int ret, mclk;
3131

32-
if (ls_card->mclk_fs) {
33-
mclk = ls_card->mclk_fs * params_rate(params);
34-
ret = snd_soc_dai_set_sysclk(cpu_dai, 0, mclk,
35-
SND_SOC_CLOCK_OUT);
36-
if (ret < 0) {
37-
dev_err(codec_dai->dev, "cpu_dai clock not set\n");
38-
return ret;
39-
}
32+
if (!ls_card->mclk_fs)
33+
return 0;
4034

41-
ret = snd_soc_dai_set_sysclk(codec_dai, 0, mclk,
42-
SND_SOC_CLOCK_IN);
43-
if (ret < 0) {
44-
dev_err(codec_dai->dev, "codec_dai clock not set\n");
45-
return ret;
46-
}
35+
mclk = ls_card->mclk_fs * params_rate(params);
36+
ret = snd_soc_dai_set_sysclk(cpu_dai, 0, mclk, SND_SOC_CLOCK_OUT);
37+
if (ret < 0) {
38+
dev_err(codec_dai->dev, "cpu_dai clock not set\n");
39+
return ret;
4740
}
41+
42+
ret = snd_soc_dai_set_sysclk(codec_dai, 0, mclk, SND_SOC_CLOCK_IN);
43+
if (ret < 0) {
44+
dev_err(codec_dai->dev, "codec_dai clock not set\n");
45+
return ret;
46+
}
47+
4848
return 0;
4949
}
5050

0 commit comments

Comments
 (0)