ARC: perf: Remove redundant initialization of variable idx

Colin Ian King · Vineet Gupta · commit e296c2e1cd70 · 2021-12-28T19:48:48.000-08:00
The variable idx is being initialized with a value that is never
read, it is being updated later on. The assignment is redundant and
can be removed.

Reviewed-by: Vladimir Isaev &lt;isaev@synopsys.com&gt;
Signed-off-by: Colin Ian King &lt;colin.i.king@gmail.com&gt;
Signed-off-by: Vineet Gupta &lt;vineetg@rivosinc.com&gt;
diff --git a/arch/arc/kernel/perf_event.c b/arch/arc/kernel/perf_event.c
@@ -361,7 +361,7 @@ static int arc_pmu_add(struct perf_event *event, int flags)
 {
 	struct arc_pmu_cpu *pmu_cpu = this_cpu_ptr(&arc_pmu_cpu);
 	struct hw_perf_event *hwc = &event->hw;
-	int idx = hwc->idx;
+	int idx;
 
 	idx = ffz(pmu_cpu->used_mask[0]);
 	if (idx == arc_pmu->n_counters)

Original file line number	Diff line number	Diff line change
`@@ -361,7 +361,7 @@ static int arc_pmu_add(struct perf_event *event, int flags)`
`361`	`361`	`{`
`362`	`362`	`struct arc_pmu_cpu *pmu_cpu = this_cpu_ptr(&arc_pmu_cpu);`
`363`	`363`	`struct hw_perf_event *hwc = &event->hw;`
`364`		`- int idx = hwc->idx;`
	`364`	`+ int idx;`
`365`	`365`
`366`	`366`	`idx = ffz(pmu_cpu->used_mask[0]);`
`367`	`367`	`if (idx == arc_pmu->n_counters)`