Skip to content

Commit e315e7b

Browse files
zhengchaoshaoPaolo Abeni
authored andcommitted
net: libwx: fix memory leak in wx_setup_rx_resources
When wx_alloc_page_pool() failed in wx_setup_rx_resources(), it doesn't release DMA buffer. Add dma_free_coherent() in the error path to release the DMA buffer. Fixes: 850b971 ("net: libwx: Allocate Rx and Tx resources") Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Link: https://lore.kernel.org/r/20230418065450.2268522-1-shaozhengchao@huawei.com Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent a5962e0 commit e315e7b

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

  • drivers/net/ethernet/wangxun/libwx

drivers/net/ethernet/wangxun/libwx/wx_lib.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1798,10 +1798,13 @@ static int wx_setup_rx_resources(struct wx_ring *rx_ring)
17981798
ret = wx_alloc_page_pool(rx_ring);
17991799
if (ret < 0) {
18001800
dev_err(rx_ring->dev, "Page pool creation failed: %d\n", ret);
1801-
goto err;
1801+
goto err_desc;
18021802
}
18031803

18041804
return 0;
1805+
1806+
err_desc:
1807+
dma_free_coherent(dev, rx_ring->size, rx_ring->desc, rx_ring->dma);
18051808
err:
18061809
kvfree(rx_ring->rx_buffer_info);
18071810
rx_ring->rx_buffer_info = NULL;

0 commit comments

Comments
 (0)