Skip to content

Commit e3217dd

Browse files
committed
parisc: Fix minor printk issues in iosapic debug code
Signed-off-by: Helge Deller <deller@gmx.de>
1 parent db7e826 commit e3217dd

1 file changed

Lines changed: 12 additions & 9 deletions

File tree

drivers/parisc/iosapic.c

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -262,9 +262,9 @@ iosapic_load_irt(unsigned long cell_num, struct irt_entry **irt)
262262

263263
if (is_pdc_pat()) {
264264
/* Use pat pdc routine to get interrupt routing table size */
265-
DBG("calling get_irt_size (cell %ld)\n", cell_num);
266265
status = pdc_pat_get_irt_size(&num_entries, cell_num);
267-
DBG("get_irt_size: %ld\n", status);
266+
DBG("calling get_irt_size (cell %ld) ", cell_num);
267+
DBG("returned %ld, entries: %lu\n", status, num_entries);
268268

269269
BUG_ON(status != PDC_OK);
270270
BUG_ON(num_entries == 0);
@@ -327,7 +327,7 @@ iosapic_load_irt(unsigned long cell_num, struct irt_entry **irt)
327327
int i;
328328

329329
printk(MODULE_NAME " Interrupt Routing Table (cell %ld)\n", cell_num);
330-
printk(MODULE_NAME " start = 0x%p num_entries %ld entry_size %d\n",
330+
printk(MODULE_NAME " start = 0x%px num_entries %ld entry_size %d\n",
331331
table,
332332
num_entries,
333333
(int) sizeof(struct irt_entry));
@@ -455,7 +455,7 @@ iosapic_xlate_pin(struct iosapic_info *isi, struct pci_dev *pcidev)
455455
pci_read_config_byte(pcidev, PCI_INTERRUPT_PIN, &intr_pin);
456456

457457
DBG_IRT("iosapic_xlate_pin(%s) SLOT %d pin %d\n",
458-
pcidev->slot_name, PCI_SLOT(pcidev->devfn), intr_pin);
458+
pci_name(pcidev), PCI_SLOT(pcidev->devfn), intr_pin);
459459

460460
if (intr_pin == 0) {
461461
/* The device does NOT support/use IRQ lines. */
@@ -508,7 +508,7 @@ iosapic_xlate_pin(struct iosapic_info *isi, struct pci_dev *pcidev)
508508
} else {
509509
intr_slot = PCI_SLOT(pcidev->devfn);
510510
}
511-
DBG_IRT("iosapic_xlate_pin: bus %d slot %d pin %d\n",
511+
DBG_IRT("iosapic_xlate_pin: bus %lld slot %d pin %d\n",
512512
pcidev->bus->busn_res.start, intr_slot, intr_pin);
513513

514514
return irt_find_irqline(isi, intr_slot, intr_pin);
@@ -733,7 +733,7 @@ int iosapic_fixup_irq(void *isi_obj, struct pci_dev *pcidev)
733733
pci_name(pcidev));
734734
return -1;
735735
}
736-
DBG_IRT("iosapic_fixup_irq(): irte %p %x %x %x %x %x %x %x %x\n",
736+
DBG_IRT("iosapic_fixup_irq(): irte %px %02x %02x %02x %02x %02x %02x %02x %04llx\n",
737737
irte,
738738
irte->entry_type,
739739
irte->entry_length,
@@ -742,12 +742,12 @@ int iosapic_fixup_irq(void *isi_obj, struct pci_dev *pcidev)
742742
irte->src_bus_id,
743743
irte->src_seg_id,
744744
irte->dest_iosapic_intin,
745-
(u32) irte->dest_iosapic_addr);
745+
irte->dest_iosapic_addr);
746746
isi_line = irte->dest_iosapic_intin;
747747

748748
/* get vector info for this input line */
749749
vi = isi->isi_vector + isi_line;
750-
DBG_IRT("iosapic_fixup_irq: line %d vi 0x%p\n", isi_line, vi);
750+
DBG_IRT("iosapic_fixup_irq: line %d vi 0x%px\n", isi_line, vi);
751751

752752
/* If this IRQ line has already been setup, skip it */
753753
if (vi->irte)
@@ -772,6 +772,8 @@ int iosapic_fixup_irq(void *isi_obj, struct pci_dev *pcidev)
772772
/* enable_irq() will use txn_* to program IRdT */
773773
vi->txn_addr = txn_alloc_addr(vi->txn_irq);
774774
vi->txn_data = txn_alloc_data(vi->txn_irq);
775+
DBG_IRT("iosapic_fixup_irq() TXN: 0x%lx 0x%x\n",
776+
vi->txn_addr, vi->txn_data);
775777

776778
vi->eoi_addr = isi->addr + IOSAPIC_REG_EOI;
777779
vi->eoi_data = cpu_to_le32(vi->txn_data);
@@ -831,7 +833,7 @@ int iosapic_serial_irq(struct parisc_device *dev)
831833

832834
/* get vector info for this input line */
833835
vi = isi->isi_vector + intin;
834-
DBG_IRT("iosapic_serial_irq: line %d vi 0x%p\n", iosapic_intin, vi);
836+
DBG_IRT("iosapic_serial_irq: line %d vi 0x%p\n", intin, vi);
835837

836838
/* If this IRQ line has already been setup, skip it */
837839
if (vi->irte)
@@ -923,6 +925,7 @@ void *iosapic_register(unsigned long hpa, void __iomem *vaddr)
923925
isi->isi_hpa = hpa;
924926
isi->isi_version = iosapic_rd_version(isi);
925927
isi->isi_num_vectors = IOSAPIC_IRDT_MAX_ENTRY(isi->isi_version) + 1;
928+
DBG_IRT("iosapic_register: num vectors = %d\n", isi->isi_num_vectors);
926929

927930
vip = isi->isi_vector = kcalloc(isi->isi_num_vectors,
928931
sizeof(struct vector_info), GFP_KERNEL);

0 commit comments

Comments
 (0)