ASoC: codecs: wcd938x: drop unnecessary mux flag assignment

jhovold · broonie · commit e358e012a69a · 2025-04-24T12:53:23.000+01:00
The codec driver data is allocated using kzalloc() so there's no need to clear the mux setup flag when mux selection fails during probe. Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Link: https://patch.msgid.link/20250415074145.7202-3-johan+linaro@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c
@@ -3280,7 +3280,6 @@ static int wcd938x_populate_dt_data(struct wcd938x_priv *wcd938x, struct device
 		ret = mux_control_try_select(wcd938x->us_euro_mux, wcd938x->mux_state);
 		if (ret) {
 			dev_err(dev, "Error (%d) Unable to select us/euro mux state\n", ret);
-			wcd938x->mux_setup_done = false;
 			return ret;
 		}
 		wcd938x->mux_setup_done = true;

Original file line number	Diff line number	Diff line change
`@@ -3280,7 +3280,6 @@ static int wcd938x_populate_dt_data(struct wcd938x_priv *wcd938x, struct device`
`3280`	`3280`	`ret = mux_control_try_select(wcd938x->us_euro_mux, wcd938x->mux_state);`
`3281`	`3281`	`if (ret) {`
`3282`	`3282`	`dev_err(dev, "Error (%d) Unable to select us/euro mux state\n", ret);`
`3283`		`- wcd938x->mux_setup_done = false;`
`3284`	`3283`	`return ret;`
`3285`	`3284`	`}`
`3286`	`3285`	`wcd938x->mux_setup_done = true;`