Skip to content

Commit e36a7b1

Browse files
krzkJonathan Corbet
authored andcommitted
docs: submitting-patches: Clarify that removal of Acks needs explanation too
The paragraph mentions only removal of Tested-by and Reviewed-by tags as action needing mentioning in patch changelog, so some developers treat it too literally. Acks, as a weaker form of review/approval, should rarely be removed, but if that happens it should be explained as well. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Signed-off-by: Jonathan Corbet <corbet@lwn.net> Message-ID: <20251126081905.7684-2-krzysztof.kozlowski@oss.qualcomm.com>
1 parent 2006f46 commit e36a7b1

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

Documentation/process/submitting-patches.rst

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -592,8 +592,9 @@ Both Tested-by and Reviewed-by tags, once received on mailing list from tester
592592
or reviewer, should be added by author to the applicable patches when sending
593593
next versions. However if the patch has changed substantially in following
594594
version, these tags might not be applicable anymore and thus should be removed.
595-
Usually removal of someone's Tested-by or Reviewed-by tags should be mentioned
596-
in the patch changelog (after the '---' separator).
595+
Usually removal of someone's Acked-by, Tested-by or Reviewed-by tags should be
596+
mentioned in the patch changelog with an explanation (after the '---'
597+
separator).
597598

598599
A Suggested-by: tag indicates that the patch idea is suggested by the person
599600
named and ensures credit to the person for the idea: if we diligently credit

0 commit comments

Comments
 (0)