powerpc: Move the use of irq_domain_add_nomap() behind a config option

Marc Zyngier · Marc Zyngier · commit e37af8011a96 · 2021-06-10T13:09:17.000+01:00
Only a handful of old PPC systems are still using the old 'nomap'
variant of the irqdomain library. Move the associated definitions
behind a configuration option, which will allow us to make some
more radical changes.

Signed-off-by: Marc Zyngier &lt;maz@kernel.org&gt;
diff --git a/arch/powerpc/platforms/cell/Kconfig b/arch/powerpc/platforms/cell/Kconfig
@@ -35,6 +35,7 @@ config PPC_IBM_CELL_BLADE
 config AXON_MSI
 	bool
 	depends on PPC_IBM_CELL_BLADE && PCI_MSI
+	select IRQ_DOMAIN_NOMAP
 	default y
 
 menu "Cell Broadband Engine options"
diff --git a/arch/powerpc/platforms/powermac/Kconfig b/arch/powerpc/platforms/powermac/Kconfig
@@ -24,6 +24,7 @@ config PPC_PMAC32_PSURGE
 	bool "Support for powersurge upgrade cards" if EXPERT
 	depends on SMP && PPC32 && PPC_PMAC
 	select PPC_SMP_MUXED_IPI
+	select IRQ_DOMAIN_NOMAP
 	default y
 	help
 	  The powersurge cpu boards can be used in the generation
diff --git a/arch/powerpc/platforms/ps3/Kconfig b/arch/powerpc/platforms/ps3/Kconfig
@@ -7,6 +7,7 @@ config PPC_PS3
 	select USB_OHCI_BIG_ENDIAN_MMIO
 	select USB_EHCI_BIG_ENDIAN_MMIO
 	select HAVE_PCI
+	select IRQ_DOMAIN_NOMAP
 	help
 	  This option enables support for the Sony PS3 game console
 	  and other platforms using the PS3 hypervisor.  Enabling this
diff --git a/arch/powerpc/sysdev/xive/Kconfig b/arch/powerpc/sysdev/xive/Kconfig
@@ -3,6 +3,7 @@ config PPC_XIVE
 	bool
 	select PPC_SMP_MUXED_IPI
 	select HARDIRQS_SW_RESEND
+	select IRQ_DOMAIN_NOMAP
 
 config PPC_XIVE_NATIVE
 	bool
diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h
@@ -345,13 +345,19 @@ static inline struct irq_domain *irq_domain_add_linear(struct device_node *of_no
 {
 	return __irq_domain_add(of_node_to_fwnode(of_node), size, size, 0, ops, host_data);
 }
+
+#ifdef CONFIG_IRQ_DOMAIN_NOMAP
 static inline struct irq_domain *irq_domain_add_nomap(struct device_node *of_node,
 					 unsigned int max_irq,
 					 const struct irq_domain_ops *ops,
 					 void *host_data)
 {
 	return __irq_domain_add(of_node_to_fwnode(of_node), 0, max_irq, max_irq, ops, host_data);
 }
+
+extern unsigned int irq_create_direct_mapping(struct irq_domain *host);
+#endif
+
 static inline struct irq_domain *irq_domain_add_tree(struct device_node *of_node,
 					 const struct irq_domain_ops *ops,
 					 void *host_data)
@@ -408,8 +414,6 @@ static inline unsigned int irq_linear_revmap(struct irq_domain *domain,
 	return irq_find_mapping(domain, hwirq);
 }
 
-extern unsigned int irq_create_direct_mapping(struct irq_domain *host);
-
 extern const struct irq_domain_ops irq_domain_simple_ops;
 
 /* stock xlate functions */
diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig
@@ -70,6 +70,11 @@ config IRQ_DOMAIN_HIERARCHY
 	bool
 	select IRQ_DOMAIN
 
+# Support for obsolete non-mapping irq domains
+config IRQ_DOMAIN_NOMAP
+	bool
+	select IRQ_DOMAIN
+
 # Support for hierarchical fasteoi+edge and fasteoi+level handlers
 config IRQ_FASTEOI_HIERARCHY_HANDLERS
 	bool
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
@@ -604,6 +604,7 @@ void irq_domain_associate_many(struct irq_domain *domain, unsigned int irq_base,
 }
 EXPORT_SYMBOL_GPL(irq_domain_associate_many);
 
+#ifdef CONFIG_IRQ_DOMAIN_NOMAP
 /**
  * irq_create_direct_mapping() - Allocate an irq for direct mapping
  * @domain: domain to allocate the irq for or NULL for default domain
@@ -644,6 +645,7 @@ unsigned int irq_create_direct_mapping(struct irq_domain *domain)
 	return virq;
 }
 EXPORT_SYMBOL_GPL(irq_create_direct_mapping);
+#endif
 
 /**
  * irq_create_mapping_affinity() - Map a hardware interrupt into linux irq space

Original file line number	Diff line number	Diff line change
`@@ -345,13 +345,19 @@ static inline struct irq_domain irq_domain_add_linear(struct device_node of_no`
`345`	`345`	`{`
`346`	`346`	`return __irq_domain_add(of_node_to_fwnode(of_node), size, size, 0, ops, host_data);`
`347`	`347`	`}`
	`348`	`+`
	`349`	`+#ifdef CONFIG_IRQ_DOMAIN_NOMAP`
`348`	`350`	`static inline struct irq_domain irq_domain_add_nomap(struct device_node of_node,`
`349`	`351`	`unsigned int max_irq,`
`350`	`352`	`const struct irq_domain_ops *ops,`
`351`	`353`	`void *host_data)`
`352`	`354`	`{`
`353`	`355`	`return __irq_domain_add(of_node_to_fwnode(of_node), 0, max_irq, max_irq, ops, host_data);`
`354`	`356`	`}`
	`357`	`+`
	`358`	`+extern unsigned int irq_create_direct_mapping(struct irq_domain *host);`
	`359`	`+#endif`
	`360`	`+`
`355`	`361`	`static inline struct irq_domain irq_domain_add_tree(struct device_node of_node,`
`356`	`362`	`const struct irq_domain_ops *ops,`
`357`	`363`	`void *host_data)`
`@@ -408,8 +414,6 @@ static inline unsigned int irq_linear_revmap(struct irq_domain *domain,`
`408`	`414`	`return irq_find_mapping(domain, hwirq);`
`409`	`415`	`}`
`410`	`416`
`411`		`-extern unsigned int irq_create_direct_mapping(struct irq_domain *host);`
`412`		`-`
`413`	`417`	`extern const struct irq_domain_ops irq_domain_simple_ops;`
`414`	`418`
`415`	`419`	`/* stock xlate functions */`
Original file line number	Diff line number	Diff line change
`@@ -604,6 +604,7 @@ void irq_domain_associate_many(struct irq_domain *domain, unsigned int irq_base,`
`604`	`604`	`}`
`605`	`605`	`EXPORT_SYMBOL_GPL(irq_domain_associate_many);`
`606`	`606`
	`607`	`+#ifdef CONFIG_IRQ_DOMAIN_NOMAP`
`607`	`608`	`/**`
`608`	`609`	`* irq_create_direct_mapping() - Allocate an irq for direct mapping`
`609`	`610`	`* @domain: domain to allocate the irq for or NULL for default domain`
`@@ -644,6 +645,7 @@ unsigned int irq_create_direct_mapping(struct irq_domain *domain)`
`644`	`645`	`return virq;`
`645`	`646`	`}`
`646`	`647`	`EXPORT_SYMBOL_GPL(irq_create_direct_mapping);`
	`648`	`+#endif`
`647`	`649`
`648`	`650`	`/**`
`649`	`651`	`* irq_create_mapping_affinity() - Map a hardware interrupt into linux irq space`