Skip to content

Commit e38f9ff

Browse files
committed
ACPI: scan: Do not add device IDs from _CID if _HID is not valid
Section 6.1.2 of ACPI 6.4 explicitly requires _HID to be present for _CID to be defined, so don't add device IDs from _CID to the device IDs list of a device if _HID is not valid. Link: https://uefi.org/specs/ACPI/6.4/06_Device_Configuration/Device_Configuration.html#cid-compatible-id Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
1 parent 1360572 commit e38f9ff

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

drivers/acpi/scan.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1340,11 +1340,11 @@ static void acpi_set_pnp_ids(acpi_handle handle, struct acpi_device_pnp *pnp,
13401340
if (info->valid & ACPI_VALID_HID) {
13411341
acpi_add_id(pnp, info->hardware_id.string);
13421342
pnp->type.platform_id = 1;
1343-
}
1344-
if (info->valid & ACPI_VALID_CID) {
1345-
cid_list = &info->compatible_id_list;
1346-
for (i = 0; i < cid_list->count; i++)
1347-
acpi_add_id(pnp, cid_list->ids[i].string);
1343+
if (info->valid & ACPI_VALID_CID) {
1344+
cid_list = &info->compatible_id_list;
1345+
for (i = 0; i < cid_list->count; i++)
1346+
acpi_add_id(pnp, cid_list->ids[i].string);
1347+
}
13481348
}
13491349
if (info->valid & ACPI_VALID_ADR) {
13501350
pnp->bus_address = info->address;

0 commit comments

Comments
 (0)