Skip to content

Commit e39ea83

Browse files
kawasakimartinkpetersen
authored andcommitted
scsi: mpi3mr: Fix missing mrioc->evtack_cmds initialization
Commit c1af985 ("scsi: mpi3mr: Add Event acknowledgment logic") introduced an array mrioc->evtack_cmds but initialization of the array elements was missed. They are just zero cleared. The function mpi3mr_complete_evt_ack() refers host_tag field of the elements. Due to the zero value of the host_tag field, the function calls clear_bit() for mrico->evtack_cmds_bitmap with wrong bit index. This results in memory access to invalid address and "BUG: KASAN: use-after-free". This BUG was observed at eHBA-9600 firmware update to version 8.3.1.0. To fix it, add the missing initialization of mrioc->evtack_cmds. Link: https://lore.kernel.org/r/20230214005019.1897251-5-shinichiro.kawasaki@wdc.com Cc: stable@vger.kernel.org Fixes: c1af985 ("scsi: mpi3mr: Add Event acknowledgment logic") Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> Acked-by: Sathya Prakash Veerichetty <sathya.prakash@broadcom.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 339e615 commit e39ea83

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

drivers/scsi/mpi3mr/mpi3mr_os.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4952,6 +4952,10 @@ mpi3mr_probe(struct pci_dev *pdev, const struct pci_device_id *id)
49524952
mpi3mr_init_drv_cmd(&mrioc->dev_rmhs_cmds[i],
49534953
MPI3MR_HOSTTAG_DEVRMCMD_MIN + i);
49544954

4955+
for (i = 0; i < MPI3MR_NUM_EVTACKCMD; i++)
4956+
mpi3mr_init_drv_cmd(&mrioc->evtack_cmds[i],
4957+
MPI3MR_HOSTTAG_EVTACKCMD_MIN + i);
4958+
49554959
if (pdev->revision)
49564960
mrioc->enable_segqueue = true;
49574961

0 commit comments

Comments
 (0)