Skip to content

Commit e3b7468

Browse files
dstarke-siemensgregkh
authored andcommitted
tty: n_gsm: fix proper link termination after failed open
Trying to open a DLCI by sending a SABM frame may fail with a timeout. The link is closed on the initiator side without informing the responder about this event. The responder assumes the link is open after sending a UA frame to answer the SABM frame. The link gets stuck in a half open state. This patch fixes this by initiating the proper link termination procedure after link setup timeout instead of silently closing it down. Fixes: e1eaea4 ("tty: n_gsm line discipline") Cc: stable@vger.kernel.org Signed-off-by: Daniel Starke <daniel.starke@siemens.com> Link: https://lore.kernel.org/r/20220218073123.2121-3-daniel.starke@siemens.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 57435c4 commit e3b7468

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/tty/n_gsm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1518,7 +1518,7 @@ static void gsm_dlci_t1(struct timer_list *t)
15181518
dlci->mode = DLCI_MODE_ADM;
15191519
gsm_dlci_open(dlci);
15201520
} else {
1521-
gsm_dlci_close(dlci);
1521+
gsm_dlci_begin_close(dlci); /* prevent half open link */
15221522
}
15231523

15241524
break;

0 commit comments

Comments
 (0)