Skip to content

Commit e3d3721

Browse files
superjamiePaolo Abeni
authored andcommitted
sctp: count singleton chunks in assoc user stats
Singleton chunks (INIT, HEARTBEAT PMTU probes, and SHUTDOWN- COMPLETE) are not counted in SCTP_GET_ASOC_STATS "sas_octrlchunks" counter available to the assoc owner. These are all control chunks so they should be counted as such. Add counting of singleton chunks so they are properly accounted for. Fixes: 196d675 ("sctp: Add support to per-association statistics via a new SCTP_GET_ASSOC_STATS call") Signed-off-by: Jamie Bainbridge <jamie.bainbridge@gmail.com> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Link: https://lore.kernel.org/r/c9ba8785789880cf07923b8a5051e174442ea9ee.1649029663.git.jamie.bainbridge@gmail.com Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent 458f5d9 commit e3d3721

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

net/sctp/outqueue.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -914,6 +914,7 @@ static void sctp_outq_flush_ctrl(struct sctp_flush_ctx *ctx)
914914
ctx->asoc->base.sk->sk_err = -error;
915915
return;
916916
}
917+
ctx->asoc->stats.octrlchunks++;
917918
break;
918919

919920
case SCTP_CID_ABORT:
@@ -938,7 +939,10 @@ static void sctp_outq_flush_ctrl(struct sctp_flush_ctx *ctx)
938939

939940
case SCTP_CID_HEARTBEAT:
940941
if (chunk->pmtu_probe) {
941-
sctp_packet_singleton(ctx->transport, chunk, ctx->gfp);
942+
error = sctp_packet_singleton(ctx->transport,
943+
chunk, ctx->gfp);
944+
if (!error)
945+
ctx->asoc->stats.octrlchunks++;
942946
break;
943947
}
944948
fallthrough;

0 commit comments

Comments
 (0)