Skip to content

Commit e416ea6

Browse files
Marios Makassikissmfrench
authored andcommitted
ksmbd: do not call kvmalloc() with __GFP_NORETRY | __GFP_NO_WARN
Commit 83dcedd ("ksmbd: fix infinite loop in ksmbd_conn_handler_loop()"), changes GFP modifiers passed to kvmalloc(). This cause xfstests generic/551 test to fail. We limit pdu length size according to connection status and maximum number of connections. In the rest, memory allocation of request is limited by credit management. so these flags are no longer needed. Fixes: 83dcedd ("ksmbd: fix infinite loop in ksmbd_conn_handler_loop()") Cc: stable@vger.kernel.org Signed-off-by: Marios Makassikis <mmakassikis@freebox.fr> Acked-by: Namjae Jeon <linkinjeon@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent 90c8ce3 commit e416ea6

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

fs/ksmbd/connection.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -326,10 +326,7 @@ int ksmbd_conn_handler_loop(void *p)
326326

327327
/* 4 for rfc1002 length field */
328328
size = pdu_size + 4;
329-
conn->request_buf = kvmalloc(size,
330-
GFP_KERNEL |
331-
__GFP_NOWARN |
332-
__GFP_NORETRY);
329+
conn->request_buf = kvmalloc(size, GFP_KERNEL);
333330
if (!conn->request_buf)
334331
break;
335332

0 commit comments

Comments
 (0)