Skip to content

Commit e44f45f

Browse files
committed
Merge tag 'clk-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux
Pull clk fixes from Stephen Boyd: "A few more clk driver fixes: - Set the max_register member of the spreadtrum regmap so that reads don't go off the end of the I/O space - Avoid a clk parent error in the i.MX imx6ul driver when the selector is unknown - Fix an oops due to REGCACHE_NONE usage by the Renesas 9-series driver" * tag 'clk-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux: clk: rs9: Fix suspend/resume clk: imx6ul: fix "failed to get parent" error clk: sprd: set max_register according to mapping range
2 parents 829cca4 + 632e047 commit e44f45f

3 files changed

Lines changed: 14 additions & 8 deletions

File tree

drivers/clk/clk-renesas-pcie.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,9 @@ static int rs9_regmap_i2c_read(void *context,
143143
static const struct regmap_config rs9_regmap_config = {
144144
.reg_bits = 8,
145145
.val_bits = 8,
146-
.cache_type = REGCACHE_NONE,
146+
.cache_type = REGCACHE_FLAT,
147147
.max_register = RS9_REG_BCP,
148+
.num_reg_defaults_raw = 0x8,
148149
.rd_table = &rs9_readable_table,
149150
.wr_table = &rs9_writeable_table,
150151
.reg_write = rs9_regmap_i2c_write,

drivers/clk/imx/clk-imx6ul.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,14 +95,16 @@ static const struct clk_div_table video_div_table[] = {
9595
{ }
9696
};
9797

98-
static const char * enet1_ref_sels[] = { "enet1_ref_125m", "enet1_ref_pad", };
98+
static const char * enet1_ref_sels[] = { "enet1_ref_125m", "enet1_ref_pad", "dummy", "dummy"};
9999
static const u32 enet1_ref_sels_table[] = { IMX6UL_GPR1_ENET1_TX_CLK_DIR,
100-
IMX6UL_GPR1_ENET1_CLK_SEL };
100+
IMX6UL_GPR1_ENET1_CLK_SEL, 0,
101+
IMX6UL_GPR1_ENET1_TX_CLK_DIR | IMX6UL_GPR1_ENET1_CLK_SEL };
101102
static const u32 enet1_ref_sels_table_mask = IMX6UL_GPR1_ENET1_TX_CLK_DIR |
102103
IMX6UL_GPR1_ENET1_CLK_SEL;
103-
static const char * enet2_ref_sels[] = { "enet2_ref_125m", "enet2_ref_pad", };
104+
static const char * enet2_ref_sels[] = { "enet2_ref_125m", "enet2_ref_pad", "dummy", "dummy"};
104105
static const u32 enet2_ref_sels_table[] = { IMX6UL_GPR1_ENET2_TX_CLK_DIR,
105-
IMX6UL_GPR1_ENET2_CLK_SEL };
106+
IMX6UL_GPR1_ENET2_CLK_SEL, 0,
107+
IMX6UL_GPR1_ENET2_TX_CLK_DIR | IMX6UL_GPR1_ENET2_CLK_SEL };
106108
static const u32 enet2_ref_sels_table_mask = IMX6UL_GPR1_ENET2_TX_CLK_DIR |
107109
IMX6UL_GPR1_ENET2_CLK_SEL;
108110

drivers/clk/sprd/common.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ static const struct regmap_config sprdclk_regmap_config = {
1717
.reg_bits = 32,
1818
.reg_stride = 4,
1919
.val_bits = 32,
20-
.max_register = 0xffff,
2120
.fast_io = true,
2221
};
2322

@@ -43,6 +42,8 @@ int sprd_clk_regmap_init(struct platform_device *pdev,
4342
struct device *dev = &pdev->dev;
4443
struct device_node *node = dev->of_node, *np;
4544
struct regmap *regmap;
45+
struct resource *res;
46+
struct regmap_config reg_config = sprdclk_regmap_config;
4647

4748
if (of_find_property(node, "sprd,syscon", NULL)) {
4849
regmap = syscon_regmap_lookup_by_phandle(node, "sprd,syscon");
@@ -59,12 +60,14 @@ int sprd_clk_regmap_init(struct platform_device *pdev,
5960
return PTR_ERR(regmap);
6061
}
6162
} else {
62-
base = devm_platform_ioremap_resource(pdev, 0);
63+
base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
6364
if (IS_ERR(base))
6465
return PTR_ERR(base);
6566

67+
reg_config.max_register = resource_size(res) - reg_config.reg_stride;
68+
6669
regmap = devm_regmap_init_mmio(&pdev->dev, base,
67-
&sprdclk_regmap_config);
70+
&reg_config);
6871
if (IS_ERR(regmap)) {
6972
pr_err("failed to init regmap\n");
7073
return PTR_ERR(regmap);

0 commit comments

Comments
 (0)