Skip to content

Commit e4ec36b

Browse files
Icenowytsbogend
authored andcommitted
MIPS: Loongson64: dts: fix phy-related definition of LS7A GMAC
Currently the LS7A GMAC device tree node lacks a proper phy-handle property pointing to the PHY node. In addition, the phy-mode property specifies "rgmii" without any internal delay information, which means the board trace needs to add 2ns delay to the RGMII data lines; but that isn't known to happen on any Loongson board. The ACPI-based initialization codepath, which is used on LoongArch-based 3A5000 + 7A1000 hardwares, specifies "rgmii-id" phy mode, which should be the one we are using. Add the lacking phy-handle property and set proper phy-mode. Tested on a LS3A4000_7A1000_NUC_BOARD_V2.1 board with YT8521S PHY. Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn> Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
1 parent 026d70d commit e4ec36b

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

arch/mips/boot/dts/loongson/ls7a-pch.dtsi

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,8 @@
199199
<13 IRQ_TYPE_LEVEL_HIGH>;
200200
interrupt-names = "macirq", "eth_lpi";
201201
interrupt-parent = <&pic>;
202-
phy-mode = "rgmii";
202+
phy-mode = "rgmii-id";
203+
phy-handle = <&phy0>;
203204
mdio {
204205
#address-cells = <1>;
205206
#size-cells = <0>;
@@ -222,7 +223,8 @@
222223
<15 IRQ_TYPE_LEVEL_HIGH>;
223224
interrupt-names = "macirq", "eth_lpi";
224225
interrupt-parent = <&pic>;
225-
phy-mode = "rgmii";
226+
phy-mode = "rgmii-id";
227+
phy-handle = <&phy1>;
226228
mdio {
227229
#address-cells = <1>;
228230
#size-cells = <0>;

0 commit comments

Comments
 (0)