Skip to content

Commit e594884

Browse files
committed
lockd: Remove unnecessary memset()
Since commit 103cc1f ("SUNRPC: Parametrize how much of argsize should be zeroed") (and possibly long before that, even) all of the memory underlying rqstp->rq_argp is zeroed already. There's no need for the memset() in nlm4svc_decode_shareargs(). Reviewed-by: Jeff Layton <jlayton@kernel.org> Reviewed-by: NeilBrown <neilb@suse.de> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent 2f746e4 commit e594884

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

fs/lockd/xdr4.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,6 @@ nlm4svc_decode_shareargs(struct svc_rqst *rqstp, struct xdr_stream *xdr)
268268
struct nlm_args *argp = rqstp->rq_argp;
269269
struct nlm_lock *lock = &argp->lock;
270270

271-
memset(lock, 0, sizeof(*lock));
272271
locks_init_lock(&lock->fl);
273272
lock->svid = ~(u32)0;
274273

0 commit comments

Comments
 (0)