Skip to content

Commit e5b1887

Browse files
Robert Richterdavejiang
authored andcommitted
cxl/hdm: Fix newline character in dev_err() messages
The newline character is not placed at the end of the string. This causes unintended line wraps, broken log level and unterminated log messages. Fix that for all messages. Note that the messages are changed to use colons now instead of parentheses, which is more common use. Fixes: 24b1819 ("cxl/hdm: Extend DVSEC range register emulation for region enumeration") Fixes: 9c57cde ("cxl/hdm: Enumerate allocated DPA") Signed-off-by: Robert Richter <rrichter@amd.com> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com> Link: https://patch.msgid.link/20260109122952.639231-1-rrichter@amd.com Signed-off-by: Dave Jiang <dave.jiang@intel.com>
1 parent 4dd05f0 commit e5b1887

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/cxl/core/hdm.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -966,7 +966,7 @@ static int cxl_setup_hdm_decoder_from_dvsec(
966966
rc = devm_cxl_dpa_reserve(cxled, *dpa_base, len, 0);
967967
if (rc) {
968968
dev_err(&port->dev,
969-
"decoder%d.%d: Failed to reserve DPA range %#llx - %#llx\n (%d)",
969+
"decoder%d.%d: Failed to reserve DPA range %#llx - %#llx: %d\n",
970970
port->id, cxld->id, *dpa_base, *dpa_base + len - 1, rc);
971971
return rc;
972972
}
@@ -1117,7 +1117,7 @@ static int init_hdm_decoder(struct cxl_port *port, struct cxl_decoder *cxld,
11171117
rc = devm_cxl_dpa_reserve(cxled, *dpa_base + skip, dpa_size, skip);
11181118
if (rc) {
11191119
dev_err(&port->dev,
1120-
"decoder%d.%d: Failed to reserve DPA range %#llx - %#llx\n (%d)",
1120+
"decoder%d.%d: Failed to reserve DPA range %#llx - %#llx: %d\n",
11211121
port->id, cxld->id, *dpa_base,
11221122
*dpa_base + dpa_size + skip - 1, rc);
11231123
return rc;

0 commit comments

Comments
 (0)