Skip to content

Commit e5cfa58

Browse files
Russell Kinggclement
authored andcommitted
ARM: dts: armada388-clearfog: add missing phy-modes
The DSA framework has got more picky about always having a phy-mode, particularly for the CPU port. Add the missing phy-mode properties for every port which does not have an integrated PHY. Add a phy-mode property to the ethernet interface facing the switch as this was configured using SGMII - as the switch is actually using 1000base-x, let's have some consistency between the two link partners. Additionally, the cpu label has never actually been used in the binding, so remove it. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
1 parent 5668d08 commit e5cfa58

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

arch/arm/boot/dts/armada-388-clearfog.dts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@
4747

4848
&eth1 {
4949
/* ethernet@30000 */
50+
phy-mode = "1000base-x";
51+
5052
fixed-link {
5153
speed = <1000>;
5254
full-duplex;
@@ -129,8 +131,9 @@
129131

130132
port@5 {
131133
reg = <5>;
132-
label = "cpu";
133134
ethernet = <&eth1>;
135+
phy-mode = "1000base-x";
136+
134137
fixed-link {
135138
speed = <1000>;
136139
full-duplex;
@@ -141,6 +144,8 @@
141144
/* 88E1512 external phy */
142145
reg = <6>;
143146
label = "lan6";
147+
phy-mode = "rgmii-id";
148+
144149
fixed-link {
145150
speed = <1000>;
146151
full-duplex;

0 commit comments

Comments
 (0)