Skip to content

Commit e5d523f

Browse files
nickdesaulnierstorvalds
authored andcommitted
ubsan: disable UBSAN_DIV_ZERO for clang
Building with UBSAN_DIV_ZERO with clang produces numerous fallthrough warnings from objtool. In the case of uncheck division, UBSAN_DIV_ZERO may introduce new control flow to check for division by zero. Because the result of the division is undefined, LLVM may optimize the control flow such that after the call to __ubsan_handle_divrem_overflow doesn't matter. If panic_on_warn was set, __ubsan_handle_divrem_overflow would panic. The problem is is that panic_on_warn is run time configurable. If it's disabled, then we cannot guarantee that we will be able to recover safely. Disable this config for clang until we can come up with a solution in LLVM. Link: ClangBuiltLinux#1657 Link: llvm/llvm-project#56289 Link: https://lore.kernel.org/lkml/CAHk-=wj1qhf7y3VNACEexyp5EbkNpdcu_542k-xZpzmYLOjiCg@mail.gmail.com/ Reported-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> Acked-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent b926f2a commit e5d523f

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

lib/Kconfig.ubsan

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,9 @@ config UBSAN_SHIFT
8484
config UBSAN_DIV_ZERO
8585
bool "Perform checking for integer divide-by-zero"
8686
depends on $(cc-option,-fsanitize=integer-divide-by-zero)
87+
# https://github.com/ClangBuiltLinux/linux/issues/1657
88+
# https://github.com/llvm/llvm-project/issues/56289
89+
depends on !CC_IS_CLANG
8790
help
8891
This option enables -fsanitize=integer-divide-by-zero which checks
8992
for integer division by zero. This is effectively redundant with the

0 commit comments

Comments
 (0)