Skip to content

Commit e67dcec

Browse files
author
Abhinav Kumar
committed
drm/msm/dpu: limit writeback modes according to max_linewidth
Writeback modes were being added according to mode_config.max_width but this is assigned to double of max_mixer_width. For compositors/clients using a single SSPP, this will fail the dpu_plane's atomic check as it checks for max_linewidth. Limit writeback modes according to max_linewidth to allow even compositors/clients which use only a single SSPP to use writeback. Fixes: 77b001a ("drm/msm/dpu: add the writeback connector layer") Reported-by: Jessica Zhang <quic_jesszhan@quicinc.com> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com> Tested-by: Jessica Zhang <quic_jesszhan@quicinc.com> # Trogdor (SC8170) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Patchwork: https://patchwork.freedesktop.org/patch/486176/ Link: https://lore.kernel.org/r/20220513225959.19004-1-quic_abhinavk@quicinc.com Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
1 parent 947a844 commit e67dcec

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,10 @@
88
static int dpu_wb_conn_get_modes(struct drm_connector *connector)
99
{
1010
struct drm_device *dev = connector->dev;
11+
struct msm_drm_private *priv = dev->dev_private;
12+
struct dpu_kms *dpu_kms = to_dpu_kms(priv->kms);
1113

12-
return drm_add_modes_noedid(connector, dev->mode_config.max_width,
14+
return drm_add_modes_noedid(connector, dpu_kms->catalog->caps->max_linewidth,
1315
dev->mode_config.max_height);
1416
}
1517

0 commit comments

Comments
 (0)