Skip to content

Commit e6a973a

Browse files
committed
iommufd/selftest: Check for overflow in IOMMU_TEST_OP_ADD_RESERVED
syzkaller found it could overflow math in the test infrastructure and cause a WARN_ON by corrupting the reserved interval tree. This only effects test kernels with CONFIG_IOMMUFD_TEST. Validate the user input length in the test ioctl. Fixes: f4b20bb ("iommufd: Add kernel support for testing iommufd") Link: https://patch.msgid.link/r/0-v1-cd99f6049ba5+51-iommufd_syz_add_resv_jgg@nvidia.com Reviewed-by: Samiullah Khawaja <skhawaja@google.com> Reviewed-by: Kevin Tian <kevin.tian@intel.com> Tested-by: Yi Liu <yi.l.liu@intel.com> Reported-by: syzbot+57fdb0cf6a0c5d1f15a2@syzkaller.appspotmail.com Closes: https://lore.kernel.org/all/69368129.a70a0220.38f243.008f.GAE@google.com Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
1 parent b80fab2 commit e6a973a

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

drivers/iommu/iommufd/selftest.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1184,14 +1184,20 @@ static int iommufd_test_add_reserved(struct iommufd_ucmd *ucmd,
11841184
unsigned int mockpt_id,
11851185
unsigned long start, size_t length)
11861186
{
1187+
unsigned long last;
11871188
struct iommufd_ioas *ioas;
11881189
int rc;
11891190

1191+
if (!length)
1192+
return -EINVAL;
1193+
if (check_add_overflow(start, length - 1, &last))
1194+
return -EOVERFLOW;
1195+
11901196
ioas = iommufd_get_ioas(ucmd->ictx, mockpt_id);
11911197
if (IS_ERR(ioas))
11921198
return PTR_ERR(ioas);
11931199
down_write(&ioas->iopt.iova_rwsem);
1194-
rc = iopt_reserve_iova(&ioas->iopt, start, start + length - 1, NULL);
1200+
rc = iopt_reserve_iova(&ioas->iopt, start, last, NULL);
11951201
up_write(&ioas->iopt.iova_rwsem);
11961202
iommufd_put_object(ucmd->ictx, &ioas->obj);
11971203
return rc;

0 commit comments

Comments
 (0)