Skip to content

Commit e749dd1

Browse files
Hersen Wualexdeucher
authored andcommitted
drm/amd/display: edp do not add non-edid timings
[Why] most edp support only timings from edid. applying non-edid timings, especially those timings out of edp bandwidth, may damage edp. [How] do not add non-edid timings for edp. Cc: Mario Limonciello <mario.limonciello@amd.com> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: stable@vger.kernel.org Acked-by: Stylon Wang <stylon.wang@amd.com> Signed-off-by: Hersen Wu <hersenxs.wu@amd.com> Reviewed-by: Roman Li <roman.li@amd.com> Tested-by: Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 34e5a54 commit e749dd1

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7196,7 +7196,13 @@ static int amdgpu_dm_connector_get_modes(struct drm_connector *connector)
71967196
drm_add_modes_noedid(connector, 1920, 1080);
71977197
} else {
71987198
amdgpu_dm_connector_ddc_get_modes(connector, edid);
7199-
amdgpu_dm_connector_add_common_modes(encoder, connector);
7199+
/* most eDP supports only timings from its edid,
7200+
* usually only detailed timings are available
7201+
* from eDP edid. timings which are not from edid
7202+
* may damage eDP
7203+
*/
7204+
if (connector->connector_type != DRM_MODE_CONNECTOR_eDP)
7205+
amdgpu_dm_connector_add_common_modes(encoder, connector);
72007206
amdgpu_dm_connector_add_freesync_modes(connector, edid);
72017207
}
72027208
amdgpu_dm_fbc_init(connector);

0 commit comments

Comments
 (0)