xfs: fix copy-paste error in previous fix

Darrick J. Wong · cmaiolino · commit e764dd439d68 · 2026-02-25T13:58:48.000+01:00
Chris Mason noticed that there is a copy-paste error in a recent change to xrep_dir_teardown that nulls out pointers after freeing the resources. Fixes: ba408d2 ("xfs: only call xf{array,blob}_destroy if we have a valid pointer") Link: https://lore.kernel.org/linux-xfs/20260205194211.2307232-1-clm@meta.com/ Reported-by: Chris Mason <clm@meta.com> Signed-off-by: "Darrick J. Wong" <djwong@kernel.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com> Signed-off-by: Carlos Maiolino <cem@kernel.org>
diff --git a/fs/xfs/scrub/dir_repair.c b/fs/xfs/scrub/dir_repair.c
@@ -177,7 +177,7 @@ xrep_dir_teardown(
 	rd->dir_names = NULL;
 	if (rd->dir_entries)
 		xfarray_destroy(rd->dir_entries);
-	rd->dir_names = NULL;
+	rd->dir_entries = NULL;
 }
 
 /* Set up for a directory repair. */

Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ xrep_dir_teardown(`
`177`	`177`	`rd->dir_names = NULL;`
`178`	`178`	`if (rd->dir_entries)`
`179`	`179`	`xfarray_destroy(rd->dir_entries);`
`180`		`- rd->dir_names = NULL;`
	`180`	`+ rd->dir_entries = NULL;`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`/* Set up for a directory repair. */`