Skip to content

Commit e7793e5

Browse files
rppttorvalds
authored andcommitted
arc: update comment about HIGHMEM implementation
Arc does not use DISCONTIGMEM to implement high memory, update the comment describing how high memory works to reflect this. Link: https://lkml.kernel.org/r/20210608091316.3622-3-rppt@kernel.org Signed-off-by: Mike Rapoport <rppt@linux.ibm.com> Acked-by: Vineet Gupta <vgupta@synopsys.com> Acked-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: David Hildenbrand <david@redhat.com> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru> Cc: Jonathan Corbet <corbet@lwn.net> Cc: Matt Turner <mattst88@gmail.com> Cc: Richard Henderson <rth@twiddle.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent fdb7d9b commit e7793e5

1 file changed

Lines changed: 5 additions & 8 deletions

File tree

arch/arc/mm/init.c

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -139,16 +139,13 @@ void __init setup_arch_memory(void)
139139

140140
#ifdef CONFIG_HIGHMEM
141141
/*
142-
* Populate a new node with highmem
143-
*
144142
* On ARC (w/o PAE) HIGHMEM addresses are actually smaller (0 based)
145-
* than addresses in normal ala low memory (0x8000_0000 based).
143+
* than addresses in normal aka low memory (0x8000_0000 based).
146144
* Even with PAE, the huge peripheral space hole would waste a lot of
147-
* mem with single mem_map[]. This warrants a mem_map per region design.
148-
* Thus HIGHMEM on ARC is imlemented with DISCONTIGMEM.
149-
*
150-
* DISCONTIGMEM in turns requires multiple nodes. node 0 above is
151-
* populated with normal memory zone while node 1 only has highmem
145+
* mem with single contiguous mem_map[].
146+
* Thus when HIGHMEM on ARC is enabled the memory map corresponding
147+
* to the hole is freed and ARC specific version of pfn_valid()
148+
* handles the hole in the memory map.
152149
*/
153150
#ifdef CONFIG_DISCONTIGMEM
154151
node_set_online(1);

0 commit comments

Comments
 (0)