Skip to content

Commit e799299

Browse files
JasonXingPaolo Abeni
authored andcommitted
netrom: Fix a data-race around sysctl_netrom_transport_maximum_tries
We need to protect the reader reading the sysctl value because the value can be changed concurrently. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Jason Xing <kernelxing@tencent.com> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent 60a7a15 commit e799299

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

net/netrom/af_netrom.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,7 @@ static int nr_create(struct net *net, struct socket *sock, int protocol,
457457
nr->t2 =
458458
msecs_to_jiffies(sysctl_netrom_transport_acknowledge_delay);
459459
nr->n2 =
460-
msecs_to_jiffies(sysctl_netrom_transport_maximum_tries);
460+
msecs_to_jiffies(READ_ONCE(sysctl_netrom_transport_maximum_tries));
461461
nr->t4 =
462462
msecs_to_jiffies(sysctl_netrom_transport_busy_delay);
463463
nr->idle =

0 commit comments

Comments
 (0)