drm/amdgpu: fix warning of drm_mm_clean

ZhenGuo Yin · alexdeucher · commit e7afa85a0d0e · 2025-04-16T15:52:49.000-04:00
Kernel doorbell BOs needs to be freed before ttm_fini. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4145 Fixes: 54c30d2 ("drm/amdgpu: create kernel doorbell pages") Acked-by: Alex Deucher <alexander.deucher@amd.com> Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: ZhenGuo Yin <zhenguo.yin@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> (cherry picked from commit 39938a8) Cc: stable@vger.kernel.org
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -3510,6 +3510,7 @@ static int amdgpu_device_ip_fini(struct amdgpu_device *adev)
 			amdgpu_device_mem_scratch_fini(adev);
 			amdgpu_ib_pool_fini(adev);
 			amdgpu_seq64_fini(adev);
+			amdgpu_doorbell_fini(adev);
 		}
 		if (adev->ip_blocks[i].version->funcs->sw_fini) {
 			r = adev->ip_blocks[i].version->funcs->sw_fini(&adev->ip_blocks[i]);
@@ -4858,7 +4859,6 @@ void amdgpu_device_fini_sw(struct amdgpu_device *adev)
 
 		iounmap(adev->rmmio);
 		adev->rmmio = NULL;
-		amdgpu_doorbell_fini(adev);
 		drm_dev_exit(idx);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -3510,6 +3510,7 @@ static int amdgpu_device_ip_fini(struct amdgpu_device *adev)`
`3510`	`3510`	`amdgpu_device_mem_scratch_fini(adev);`
`3511`	`3511`	`amdgpu_ib_pool_fini(adev);`
`3512`	`3512`	`amdgpu_seq64_fini(adev);`
	`3513`	`+ amdgpu_doorbell_fini(adev);`
`3513`	`3514`	`}`
`3514`	`3515`	`if (adev->ip_blocks[i].version->funcs->sw_fini) {`
`3515`	`3516`	`r = adev->ip_blocks[i].version->funcs->sw_fini(&adev->ip_blocks[i]);`
`@@ -4858,7 +4859,6 @@ void amdgpu_device_fini_sw(struct amdgpu_device *adev)`
`4858`	`4859`
`4859`	`4860`	`iounmap(adev->rmmio);`
`4860`	`4861`	`adev->rmmio = NULL;`
`4861`		`- amdgpu_doorbell_fini(adev);`
`4862`	`4862`	`drm_dev_exit(idx);`
`4863`	`4863`	`}`
`4864`	`4864`