i2c: i2c-xiic: Replace dev_err() with dev_err_probe() in probe function

zandae · Andi Shyti · commit e7d8a0de7039 · 2025-05-19T22:23:55.000+02:00
This simplifies the code while improving log. Signed-off-by: Enrico Zanda <e.zanda1@gmail.com> Link: https://lore.kernel.org/r/20250415183447.396277-10-e.zanda1@gmail.com Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
@@ -1489,7 +1489,7 @@ static int xiic_i2c_probe(struct platform_device *pdev)
 					pdev->name, i2c);
 
 	if (ret < 0) {
-		dev_err(&pdev->dev, "Cannot claim IRQ\n");
+		dev_err_probe(&pdev->dev, ret, "Cannot claim IRQ\n");
 		goto err_pm_disable;
 	}
 
@@ -1510,7 +1510,7 @@ static int xiic_i2c_probe(struct platform_device *pdev)
 
 	ret = xiic_reinit(i2c);
 	if (ret < 0) {
-		dev_err(&pdev->dev, "Cannot xiic_reinit\n");
+		dev_err_probe(&pdev->dev, ret, "Cannot xiic_reinit\n");
 		goto err_pm_disable;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1489,7 +1489,7 @@ static int xiic_i2c_probe(struct platform_device *pdev)`
`1489`	`1489`	`pdev->name, i2c);`
`1490`	`1490`
`1491`	`1491`	`if (ret < 0) {`
`1492`		`- dev_err(&pdev->dev, "Cannot claim IRQ\n");`
	`1492`	`+ dev_err_probe(&pdev->dev, ret, "Cannot claim IRQ\n");`
`1493`	`1493`	`goto err_pm_disable;`
`1494`	`1494`	`}`
`1495`	`1495`
`@@ -1510,7 +1510,7 @@ static int xiic_i2c_probe(struct platform_device *pdev)`
`1510`	`1510`
`1511`	`1511`	`ret = xiic_reinit(i2c);`
`1512`	`1512`	`if (ret < 0) {`
`1513`		`- dev_err(&pdev->dev, "Cannot xiic_reinit\n");`
	`1513`	`+ dev_err_probe(&pdev->dev, ret, "Cannot xiic_reinit\n");`
`1514`	`1514`	`goto err_pm_disable;`
`1515`	`1515`	`}`
`1516`	`1516`