bcache: set pdev_set_uuid before scond loop iteration

cybertan · axboe · commit e80927079fd9 · 2021-01-09T09:21:03.000-07:00
There is no need to reassign pdev_set_uuid in the second loop iteration,
so move it to the place before second loop.

Signed-off-by: Yi Li &lt;yili@winhong.com&gt;
Signed-off-by: Coly Li &lt;colyli@suse.de&gt;
Signed-off-by: Jens Axboe &lt;axboe@kernel.dk&gt;
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
@@ -2644,8 +2644,8 @@ static ssize_t bch_pending_bdevs_cleanup(struct kobject *k,
 	}
 
 	list_for_each_entry_safe(pdev, tpdev, &pending_devs, list) {
+		char *pdev_set_uuid = pdev->dc->sb.set_uuid;
 		list_for_each_entry_safe(c, tc, &bch_cache_sets, list) {
-			char *pdev_set_uuid = pdev->dc->sb.set_uuid;
 			char *set_uuid = c->set_uuid;
 
 			if (!memcmp(pdev_set_uuid, set_uuid, 16)) {

Original file line number	Diff line number	Diff line change
`@@ -2644,8 +2644,8 @@ static ssize_t bch_pending_bdevs_cleanup(struct kobject *k,`
`2644`	`2644`	`}`
`2645`	`2645`
`2646`	`2646`	`list_for_each_entry_safe(pdev, tpdev, &pending_devs, list) {`
	`2647`	`+ char *pdev_set_uuid = pdev->dc->sb.set_uuid;`
`2647`	`2648`	`list_for_each_entry_safe(c, tc, &bch_cache_sets, list) {`
`2648`		`- char *pdev_set_uuid = pdev->dc->sb.set_uuid;`
`2649`	`2649`	`char *set_uuid = c->set_uuid;`
`2650`	`2650`
`2651`	`2651`	`if (!memcmp(pdev_set_uuid, set_uuid, 16)) {`