Skip to content

Commit e83a447

Browse files
Sebastian Andrzej Siewiortorvalds
authored andcommitted
panic: remove oops_id
The oops id has been added as part of the end of trace marker for the kerneloops.org project. The id is used to automatically identify duplicate submissions of the same report. Identical looking reports with different a id can be considered as the same oops occurred again. The early initialisation of the oops_id can create a warning if the random core is not yet fully initialized. On PREEMPT_RT it is problematic if the id is initialized on demand from non preemptible context. The kernel oops project is not available since 2017. Remove the oops_id and use 0 in the output in case parser rely on it. Link: https://bugs.debian.org/953172 Link: https://lkml.kernel.org/r/Ybdi16aP2NEugWHq@linutronix.de Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Cc: Arjan van de Ven <arjan@linux.intel.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 23b36fe commit e83a447

1 file changed

Lines changed: 1 addition & 18 deletions

File tree

kernel/panic.c

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -534,26 +534,9 @@ void oops_enter(void)
534534
trigger_all_cpu_backtrace();
535535
}
536536

537-
/*
538-
* 64-bit random ID for oopses:
539-
*/
540-
static u64 oops_id;
541-
542-
static int init_oops_id(void)
543-
{
544-
if (!oops_id)
545-
get_random_bytes(&oops_id, sizeof(oops_id));
546-
else
547-
oops_id++;
548-
549-
return 0;
550-
}
551-
late_initcall(init_oops_id);
552-
553537
static void print_oops_end_marker(void)
554538
{
555-
init_oops_id();
556-
pr_warn("---[ end trace %016llx ]---\n", (unsigned long long)oops_id);
539+
pr_warn("---[ end trace %016llx ]---\n", 0ULL);
557540
}
558541

559542
/*

0 commit comments

Comments
 (0)