nfsd: add more info to WARN_ON_ONCE on failed callbacks

jtlayton · chucklever · commit e8581a912447 · 2024-09-20T19:31:03.000-04:00
Currently, you get the warning and stack trace, but nothing is printed
about the relevant error codes. Add that in.

Signed-off-by: Jeff Layton &lt;jlayton@kernel.org&gt;
Signed-off-by: Chuck Lever &lt;chuck.lever@oracle.com&gt;
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
@@ -1333,7 +1333,8 @@ static void nfsd4_cb_done(struct rpc_task *task, void *calldata)
 		return;
 
 	if (cb->cb_status) {
-		WARN_ON_ONCE(task->tk_status);
+		WARN_ONCE(task->tk_status, "cb_status=%d tk_status=%d",
+			  cb->cb_status, task->tk_status);
 		task->tk_status = cb->cb_status;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1333,7 +1333,8 @@ static void nfsd4_cb_done(struct rpc_task task, void calldata)`
`1333`	`1333`	`return;`
`1334`	`1334`
`1335`	`1335`	`if (cb->cb_status) {`
`1336`		`- WARN_ON_ONCE(task->tk_status);`
	`1336`	`+ WARN_ONCE(task->tk_status, "cb_status=%d tk_status=%d",`
	`1337`	`+ cb->cb_status, task->tk_status);`
`1337`	`1338`	`task->tk_status = cb->cb_status;`
`1338`	`1339`	`}`
`1339`	`1340`