xfs: remove q_qlock locking in xfs_qm_scall_setqlim

Christoph Hellwig · cmaiolino · commit e85e74e4c9a6 · 2025-11-11T11:45:58.000+01:00
q_type can't change for an existing dquot, so there is no need for
the locking here.

Signed-off-by: Christoph Hellwig &lt;hch@lst.de&gt;
Reviewed-by: Darrick J. Wong &lt;djwong@kernel.org&gt;
Signed-off-by: Carlos Maiolino &lt;cem@kernel.org&gt;
diff --git a/fs/xfs/xfs_qm_syscalls.c b/fs/xfs/xfs_qm_syscalls.c
@@ -302,9 +302,7 @@ xfs_qm_scall_setqlim(
 		return error;
 	}
 
-	mutex_lock(&dqp->q_qlock);
 	defq = xfs_get_defquota(q, xfs_dquot_type(dqp));
-	mutex_unlock(&dqp->q_qlock);
 
 	error = xfs_trans_alloc(mp, &M_RES(mp)->tr_qm_setqlim, 0, 0, 0, &tp);
 	if (error)

Original file line number	Diff line number	Diff line change
`@@ -302,9 +302,7 @@ xfs_qm_scall_setqlim(`
`302`	`302`	`return error;`
`303`	`303`	`}`
`304`	`304`
`305`		`- mutex_lock(&dqp->q_qlock);`
`306`	`305`	`defq = xfs_get_defquota(q, xfs_dquot_type(dqp));`
`307`		`- mutex_unlock(&dqp->q_qlock);`
`308`	`306`
`309`	`307`	`error = xfs_trans_alloc(mp, &M_RES(mp)->tr_qm_setqlim, 0, 0, 0, &tp);`
`310`	`308`	`if (error)`