orangefs_inode_is_stale(): i_mode type bits do *not* form a bitmap...

Al Viro · Al Viro · commit e89f00d602b1 · 2021-03-12T22:15:17.000-05:00
Signed-off-by: Al Viro &lt;viro@zeniv.linux.org.uk&gt;
diff --git a/fs/orangefs/orangefs-utils.c b/fs/orangefs/orangefs-utils.c
@@ -221,7 +221,7 @@ static int orangefs_inode_is_stale(struct inode *inode,
 	 * If the inode type or symlink target have changed then this
 	 * inode is stale.
 	 */
-	if (type == -1 || !(inode->i_mode & type)) {
+	if (type == -1 || inode_wrong_type(inode, type)) {
 		orangefs_make_bad_inode(inode);
 		return 1;
 	}

Original file line number	Diff line number	Diff line change
`@@ -221,7 +221,7 @@ static int orangefs_inode_is_stale(struct inode *inode,`
`221`	`221`	`* If the inode type or symlink target have changed then this`
`222`	`222`	`* inode is stale.`
`223`	`223`	`*/`
`224`		`- if (type == -1 \|\| !(inode->i_mode & type)) {`
	`224`	`+ if (type == -1 \|\| inode_wrong_type(inode, type)) {`
`225`	`225`	`orangefs_make_bad_inode(inode);`
`226`	`226`	`return 1;`
`227`	`227`	`}`