Skip to content

Commit e8bc0c1

Browse files
Farah-kassabriogabbay
authored andcommitted
accel/habanalabs: add log when eq event is not received
Add error log when no eq event is received from FW, to cover a scenario when FW is stuck for some reason. In such case driver will not receive neither the eq error interrupt or the eq heartbeat event, and will just initiate a reset without indication in the dmesg about the reason. Signed-off-by: Farah Kassabri <fkassabri@habana.ai> Reviewed-by: Oded Gabbay <ogabbay@kernel.org> Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
1 parent c648548 commit e8bc0c1

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

drivers/accel/habanalabs/common/device.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1049,10 +1049,12 @@ static void hl_device_eq_heartbeat(struct hl_device *hdev)
10491049
if (!prop->cpucp_info.eq_health_check_supported)
10501050
return;
10511051

1052-
if (hdev->eq_heartbeat_received)
1052+
if (hdev->eq_heartbeat_received) {
10531053
hdev->eq_heartbeat_received = false;
1054-
else
1054+
} else {
1055+
dev_err(hdev->dev, "EQ heartbeat event was not received!\n");
10551056
hl_device_cond_reset(hdev, HL_DRV_RESET_HARD, event_mask);
1057+
}
10561058
}
10571059

10581060
static void hl_device_heartbeat(struct work_struct *work)

0 commit comments

Comments
 (0)