Skip to content

Commit e8bc14d

Browse files
Christoph Hellwigaxboe
authored andcommitted
block: remove the blk_flush_integrity call in blk_integrity_unregister
Now that there are no indirect calls for PI processing there is no way to dereference a NULL pointer here. Additionally drivers now always freeze the queue (or in case of stacking drivers use their internal equivalent) around changing the integrity profile. This is effectively a revert of commit 3df4996 ("block: flush the integrity workqueue in blk_integrity_unregister"). Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com> Reviewed-by: Hannes Reinecke <hare@suse.de> Link: https://lore.kernel.org/r/20240613084839.1044015-7-hch@lst.de Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent e9f5f44 commit e8bc14d

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

block/blk-integrity.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -401,8 +401,6 @@ void blk_integrity_unregister(struct gendisk *disk)
401401
if (!bi->tuple_size)
402402
return;
403403

404-
/* ensure all bios are off the integrity workqueue */
405-
blk_flush_integrity();
406404
blk_queue_flag_clear(QUEUE_FLAG_STABLE_WRITES, disk->queue);
407405
memset(bi, 0, sizeof(*bi));
408406
}

0 commit comments

Comments
 (0)