Skip to content

Commit e8c2da7

Browse files
Jonathan Hsumartinkpetersen
authored andcommitted
scsi: ufs: Fix illegal offset in UPIU event trace
Fix incorrect index for UTMRD reference in ufshcd_add_tm_upiu_trace(). Link: https://lore.kernel.org/r/20210924085848.25500-1-jonathan.hsu@mediatek.com Fixes: 4b42d55 ("scsi: ufs: core: Fix wrong Task Tag used in task management request UPIUs") Cc: stable@vger.kernel.org Reviewed-by: Stanley Chu <stanley.chu@mediatek.com> Reviewed-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Jonathan Hsu <jonathan.hsu@mediatek.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent fbdac19 commit e8c2da7

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/scsi/ufs/ufshcd.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -318,8 +318,7 @@ static void ufshcd_add_query_upiu_trace(struct ufs_hba *hba,
318318
static void ufshcd_add_tm_upiu_trace(struct ufs_hba *hba, unsigned int tag,
319319
enum ufs_trace_str_t str_t)
320320
{
321-
int off = (int)tag - hba->nutrs;
322-
struct utp_task_req_desc *descp = &hba->utmrdl_base_addr[off];
321+
struct utp_task_req_desc *descp = &hba->utmrdl_base_addr[tag];
323322

324323
if (!trace_ufshcd_upiu_enabled())
325324
return;

0 commit comments

Comments
 (0)